Skip to content

fix(openspec): address PR #455 markdown findings - #456

Merged
djm81 merged 1 commit into
devfrom
bugfix/pr455-markdown-review-findings
Aug 30, 2026
Merged

djm81 merged 1 commit into
devfrom
bugfix/pr455-markdown-review-findings

Conversation

@djm81

@djm81 djm81 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix only the six Markdown/OpenSpec review findings reported on promotion PR #455. No Python, workflow, package manifest, registry, version, signature, or runtime implementation file changes are included.

Review findings addressed

  • Move abandoned, never-implemented R08 planning out of the completed OpenSpec archive into non-canonical abandoned history.
  • Finalize completed module-scope-02-preserve-user-installs through openspec archive, promoting its accepted specification delta.
  • Remove stale active R08 ownership/follow-up guidance from R07 artifacts.
  • Correct the [Change] Validate bounded red-green replay capsules #414 and core #675 closure date to 2026-08-27.
  • Make in-memory import eviction, or an equivalent before-import guarantee, mandatory while preserving user-scoped files.
  • Define the required core chore(registry): publish changed modules #251 verified-install-result-v1 contract and fail-closed adapter consumption before implementation.

Scope

Verification

  • openspec archive -y module-scope-02-preserve-user-installs: passed; canonical agent-governance-loading specification updated.
  • openspec validate --all --strict: 81 passed, 0 failed.
  • Complete staged ./scripts/pre-commit-quality-checks.sh all: passed.
  • Requirements evidence gate: passed.
  • YAML validation, formatting, import-boundary, command overview/contract, documentation-accountability, and docs-site checks: passed.
  • Signed Conventional Commit and all commit hooks: passed.
  • git diff --check: passed.

Rollback

Revert this single PR commit. That restores the previous planning locations and wording; no runtime or immutable release artifact rollback is required.

@djm81 djm81 added bug Something isn't working documentation Improvements or additions to documentation openspec openspec change labels Aug 30, 2026
@djm81 djm81 self-assigned this Aug 30, 2026
@strix-security

Copy link
Copy Markdown

Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here.

So far, Strix has reviewed 48 pull requests across this workspace.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T13:47:04.352137Z e83bcea PR opened
🔒 Security Review ✅ Completed 2026-08-30T13:47:53.930054Z e83bcea PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 21 days. After that, they cost $0.25 per reviewed file.

Or wait 39 minutes for your next included review.

View limit details

Limit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9d66bc4b-51f5-4c9d-9084-d03c572cbdef

📥 Commits

Reviewing files that changed from the base of the PR and between 6b4f563 and e83bcea.

📒 Files selected for processing (32)
  • openspec/CHANGE_ORDER.md
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/.openspec.yaml
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/TDD_EVIDENCE.md
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/design.md
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/proposal.md
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/requirements-evidence.yaml
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/specs/agent-governance-loading/spec.md
  • openspec/changes/archive/2026-08-30-module-scope-02-preserve-user-installs/tasks.md
  • openspec/changes/preflight-04-harness-adapters/CHANGE_VALIDATION.md
  • openspec/changes/preflight-04-harness-adapters/design.md
  • openspec/changes/preflight-04-harness-adapters/requirements-evidence.yaml
  • openspec/changes/preflight-04-harness-adapters/specs/preflight-harness-adapters/spec.md
  • openspec/changes/preflight-04-harness-adapters/tasks.md
  • openspec/changes/requirements-07-scenario-runtime-proof/README.md
  • openspec/changes/requirements-07-scenario-runtime-proof/TDD_EVIDENCE.md
  • openspec/changes/requirements-07-scenario-runtime-proof/design.md
  • openspec/changes/requirements-07-scenario-runtime-proof/proposal.md
  • openspec/changes/requirements-07-scenario-runtime-proof/requirements-evidence.yaml
  • openspec/changes/requirements-07-scenario-runtime-proof/specs/requirements-scenario-runtime-proof/spec.md
  • openspec/changes/requirements-07-scenario-runtime-proof/tasks.md
  • openspec/history/README.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/.openspec.yaml
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/CHANGE_VALIDATION.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/README.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/TDD_EVIDENCE.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/design.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/proposal.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/requirements-evidence.yaml
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/specs/requirements-bounded-red-green-proof/spec.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/specs/requirements-proof-review-context/spec.md
  • openspec/history/abandoned/2026-08-30-requirements-08-bounded-red-green-proof/tasks.md
  • openspec/specs/agent-governance-loading/spec.md

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@djm81 djm81 moved this to In Progress in SpecFact CLI Aug 30, 2026
@djm81
djm81 merged commit 14658da into dev Aug 30, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SpecFact CLI Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation openspec openspec change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant